feat(cli): show startup progress before TUI#36369
Closed
H-TTTTT wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this implementation because the current v2 startup path has been superseded by #36448, #36455, and #36475. Those changes now own the update/version-mismatch renderer handoff. Rebasing this branch as-is would create competing terminal renderers and would regress the newer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36195
Type of change
What does this PR do?
V2 can spend several seconds resolving or restarting its background service and loading the initial location before the full-screen renderer exists. During that time the terminal currently looks frozen.
This starts the existing timeline footer after 500 ms, keeps it visible through the initial API preflight, and explicitly releases terminal ownership before the TUI renderer starts. Fast startup creates no renderer or output. Non-TTY launches retain the existing plain stderr diagnostics, and explicit
--serverlaunches keep their current behavior.The handoff also waits for in-flight timeline creation and cleanup. If terminal ownership cannot be released, startup fails instead of allowing two renderers to compete for stdin/stdout.
How did you verify your code works?
bun test src/ui/startup.test.ts: 12 passedbun test test/app-lifecycle.test.tsx: 5 passedScreenshots / recordings
PTY smoke testing confirmed that the existing split-footer renderer shows
Starting OpenCode...only after the delay and is destroyed before the full TUI renderer starts.Checklist